Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/631 debug azurite configuration #651

Merged
merged 8 commits into from
Nov 2, 2022

Conversation

HofmeisterAn
Copy link
Collaborator

What does this PR do?

This PR contains several minor fixes and improvements to increase the Testcontainers for .NET development experience. Some configurations are very strict. This makes it unnecessarily difficult for developers to set up their test environment. These changes will support more variety of configurations.

Why is it important?

  • The ImageFromDockerfileConfiguration configuration did not work properly with file paths that contains backward slashes. Especially, on Windows machines backward slashes are common. Supporting backward slashes makes it more convenient for the developers to work with Testcontainesr for .NET.
  • It adds the CLI commands to checkout and run the Weather Forecase example immediately. Developers do not need to enter the CLI commands manually anymore.
  • It contains an improvement that may fix an issue with the Azurite configuration. Somehow, some Azurite containers response with the wrong service while the connection string is correct. This may relate to a wrong entrypoint.

Related issues

@netlify
Copy link

netlify bot commented Nov 2, 2022

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit b1fc640
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/63627b5f881f9300080cc88a
😎 Deploy Preview https://deploy-preview-651--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@HofmeisterAn HofmeisterAn merged commit 87914f3 into develop Nov 2, 2022
@HofmeisterAn HofmeisterAn deleted the bugfix/631-debug-azurite-configuration branch November 2, 2022 14:39
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant